Fixes #277 relationship match return node set #642
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The documentation states, that a call to match() should return a NodeSet. This change will however break existing code which expects match() to return a Traversal.
This change was added to allow some backwards compatibility when working with RelationshipManager.match(), which now returns a NodeSet as was originally described in the documentation.
Collaborator
|
@AntonLydike This looks like a good candidate to incorporate in the next round of changes. Is there any reason not to? |
|
SonarCloud Quality Gate failed.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt at fixing #277. I am not sure if such a breaking change would be justified though. Looking at the code, I definitely get the feeling, that it's supposed to return a NodeSet.
This probably has to wait for the next minor or even major release for that reason...